fix(css): apply server.origin to public file urls in CSS (fix #18457)#21697
Open
SalvatoreT wants to merge 1 commit intovitejs:mainfrom
Open
fix(css): apply server.origin to public file urls in CSS (fix #18457)#21697SalvatoreT wants to merge 1 commit intovitejs:mainfrom
SalvatoreT wants to merge 1 commit intovitejs:mainfrom
Conversation
4 tasks
sapphi-red
reviewed
Feb 25, 2026
…18457) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9f768c5 to
1068e87
Compare
Author
|
The CI failure looks unrelated to my change. https://github.com/vitejs/vite/actions/runs/22411489370/job/64885922055?pr=21697#step:3:13 |
sapphi-red
requested changes
Feb 26, 2026
Member
sapphi-red
left a comment
There was a problem hiding this comment.
The both tests added passes even if I reverted the changes in css.ts. Would you change the test so that it covers the fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18457
Vite's CSS plugin rewrites url() references during dev by resolving them to absolute URLs with the dev server's origin hardcoded. The
server.originconfig exists but is only applied in some code paths (module assets in templates and JS imports) but not in others (CSS url() rewriting path).Similar to @kajic on #18457, I have a
basefor creating the HTML and a different one for the Vite server.This change just lest the
server.originalso get applied to the CSS files too.